Hi Joyce, > -----Original Message----- > From: Joyce Kong <[email protected]> > Sent: Monday, August 23, 2021 1:50 PM > To: Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; > Ananyev, Konstantin <[email protected]>; Nicolau, Radu > <[email protected]>; Akhil Goyal <[email protected]>; Doherty, Declan > <[email protected]>; Sunil Kumar Kori <[email protected]>; Pavan > Nikhilesh <[email protected]>; Richardson, Bruce > <[email protected]>; Hunt, David <[email protected]>; Burakov, > Anatoly <[email protected]>; Marohn, Byron <[email protected]>; > Wang, Yipeng1 <[email protected]>; Maxime Coquelin > <[email protected]>; Xia, Chenbo <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected] > Subject: [PATCH v2 8/8] examples: remove unnecessary include of atomic > > Remove the unnecessary header file rte_atomic.h > included in example module. > > Signed-off-by: Joyce Kong <[email protected]> > Reviewed-by: Ruifeng Wang <[email protected]> > --- > examples/bond/main.c | 1 - > examples/ip_fragmentation/main.c | 1 - > examples/ip_reassembly/main.c | 1 - > examples/ipsec-secgw/ipsec-secgw.c | 1 - > examples/ipv4_multicast/main.c | 1 - > examples/l2fwd-crypto/main.c | 1 - > examples/l2fwd-event/l2fwd_common.h | 1 - > examples/l2fwd-event/l2fwd_event.c | 1 - > examples/l2fwd-keepalive/main.c | 1 - > examples/l2fwd/main.c | 1 - > examples/l3fwd-acl/main.c | 1 - > examples/l3fwd-power/main.c | 1 - > examples/l3fwd/main.c | 1 - > examples/link_status_interrupt/main.c | 1 - > examples/multi_process/client_server_mp/mp_client/client.c | 1 - > examples/multi_process/client_server_mp/mp_server/init.c | 1 - > examples/multi_process/simple_mp/main.c | 1 - > examples/multi_process/simple_mp/mp_commands.c | 1 - > examples/multi_process/symmetric_mp/main.c | 1 - > examples/server_node_efd/node/node.c | 1 - > examples/server_node_efd/server/init.c | 1 - > examples/vhost_blk/blk.c | 1 - > examples/vhost_blk/vhost_blk.c | 1 -
In vhost_blk.c, some atomic API is used (rte_atomic_thread_fence). Although it compiles well, I think it's better to keep the include rather than depending on other header includes rte_atomic.h. Thanks, Chenbo > examples/vm_power_manager/channel_manager.c | 1 - > examples/vm_power_manager/channel_manager.h | 1 - > examples/vmdq/main.c | 1 - > examples/vmdq_dcb/main.c | 1 - > 27 files changed, 27 deletions(-)
