On 2021-08-27 12:18, Xueming(Steven) Li wrote:
-----Original Message-----
From: Andrew Rybchenko <[email protected]>
Sent: Wednesday, August 18, 2021 10:00 PM
To: Ajit Khaparde <[email protected]>; Somnath Kotur
<[email protected]>; John Daley
<[email protected]>; Hyong Youb Kim <[email protected]>; Beilei Xing
<[email protected]>; Qiming Yang
<[email protected]>; Qi Zhang <[email protected]>; Haiyue Wang
<[email protected]>; Matan Azrad
<[email protected]>; Shahaf Shuler <[email protected]>; Slava
Ovsiienko <[email protected]>; NBU-Contact-Thomas
Monjalon <[email protected]>; Ferruh Yigit <[email protected]>
Cc: [email protected]; Viacheslav Galaktionov
<[email protected]>; Xueming(Steven) Li
<[email protected]>
Subject: [PATCH v2] ethdev: fix representor port ID search by name
From: Viacheslav Galaktionov <[email protected]>
Getting a list of representors from a representor does not make sense.
Instead, a parent device should be used.
To this end, extend the rte_eth_dev_data structure to include the port
ID of the parent device for representors.
Signed-off-by: Viacheslav Galaktionov
<[email protected]>
Signed-off-by: Andrew Rybchenko <[email protected]>
---
[snip]
b/drivers/net/mlx5/windows/mlx5_os.c
index 7e1df1c751..0c5a02bfcb 100644
--- a/drivers/net/mlx5/windows/mlx5_os.c
+++ b/drivers/net/mlx5/windows/mlx5_os.c
@@ -543,6 +543,23 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
if (priv->representor) {
eth_dev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR;
eth_dev->data->representor_id = priv->representor_id;
+ MLX5_ETH_FOREACH_DEV(port_id, priv->pci_dev) {
+ struct mlx5_priv *opriv =
+ rte_eth_devices[port_id].data->dev_private;
+ if (opriv &&
+ opriv->master &&
+ opriv->domain_id == priv->domain_id &&
+ opriv->sh == priv->sh) {
+ eth_dev->data->parent_port_id =
+ rte_eth_devices[port_id].data->port_id;
Could this value different than port_id?
Oh, yes, that's an oversight. Thank you!
+ break;
+ }
+ }
+ if (port_id >= RTE_MAX_ETHPORTS) {
+ DRV_LOG(ERR, "no master device for representor");
+ err = ENODEV;
+ goto error;
Here shouldn't be an error.
What do you mean? Is it normal not to have a master device for a
representor?
Parent port ID default to 0, it could be wrong if multiple PF probed,
let's default to current port ID.
What is the "current" port ID here? Do you mean the representor's port
ID?
If you are talking about the value of the port_id variable, then I
suppose it
could be set to RTE_MAX_ETHPORTS explicitly if a master device isn't
found.
[snip]
