On 8/31/21 7:32 PM, Wang, Haiyue wrote: >> -----Original Message----- >> From: Andrew Rybchenko <[email protected]> >> Sent: Wednesday, September 1, 2021 00:06 >> To: Ajit Khaparde <[email protected]>; Somnath Kotur >> <[email protected]>; Daley, >> John <[email protected]>; Hyong Youb Kim <[email protected]>; Xing, Beilei >> <[email protected]>; >> Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; >> Wang, Haiyue >> <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler >> <[email protected]>; >> Viacheslav Ovsiienko <[email protected]>; Thomas Monjalon >> <[email protected]>; Yigit, Ferruh >> <[email protected]> >> Cc: [email protected]; Viacheslav Galaktionov >> <[email protected]> >> Subject: [PATCH v4] ethdev: fix representor port ID search by name >> >> From: Viacheslav Galaktionov <[email protected]> >> >> Getting a list of representors from a representor does not make sense. >> Instead, a parent device should be used. >> >> To this end, extend the rte_eth_dev_data structure to include the port ID >> of the backing device for representors. >> >> Signed-off-by: Viacheslav Galaktionov <[email protected]> >> Signed-off-by: Andrew Rybchenko <[email protected]> >> --- >> The new field is added into the hole in rte_eth_dev_data structure. >> The patch does not change ABI, but extra care is required since ABI >> check is disabled for the structure because of the libabigail bug [1]. >> >> Potentially it is bad for out-of-tree drivers which implement >> representors but do not fill in a new parert_port_id field in >> rte_eth_dev_data structure. Do we care? > > Set the `parent_port_id` to ' RTE_MAX_ETHPORTS' as an invalid port ID > in rte_eth_dev_allocate ?
I like the idea. It should be safer this way. Many thanks.
