> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Wednesday, September 1, 2021 12:59 AM
> To: Peng, ZhihongX <[email protected]>
> Cc: [email protected]; [email protected]; [email protected]
> Subject: Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit
>
> On Tue, 31 Aug 2021 10:28:44 +0800
> [email protected] wrote:
>
> > From: Zhihong Peng <[email protected]>
> >
> > Malloc cl in the cmdline_stdin_new function, so release in the
> > cmdline_stdin_exit function is logical, so that cl will not be
> > released alone.
> >
> > Fixes: af75078fece3 (first public release)
> > Cc: [email protected]
> >
> > Signed-off-by: Zhihong Peng <[email protected]>
> > ---
> > lib/cmdline/cmdline_socket.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/cmdline/cmdline_socket.c
> > b/lib/cmdline/cmdline_socket.c index 998e8ade25..ebd5343754 100644
> > --- a/lib/cmdline/cmdline_socket.c
> > +++ b/lib/cmdline/cmdline_socket.c
> > @@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl)
> > return;
> >
> > terminal_restore(cl);
> > + cmdline_free(cl);
> > }
>
> How did you find this? valgrind? address-sanitizer?
Use address-sanitizer.
