On Tue, Sep 7, 2021 at 2:20 PM Kundapura, Ganapati <ganapati.kundap...@intel.com> wrote: > > > > > -----Original Message----- > > From: Jerin Jacob <jerinjac...@gmail.com> > > Sent: 07 September 2021 13:42 > > To: Kundapura, Ganapati <ganapati.kundap...@intel.com> > > Cc: Jayatheerthan, Jay <jay.jayatheert...@intel.com>; dpdk-dev > > <dev@dpdk.org>; Pavan Nikhilesh <pbhagavat...@marvell.com> > > Subject: Re: [PATCH v3 1/3] eventdev: add rx queue info get api > > > > in > > > > On Tue, Sep 7, 2021 at 12:15 PM Ganapati Kundapura > > <ganapati.kundap...@intel.com> wrote: > > > > > > Added rte_event_eth_rx_adapter_queue_info_get() API to get rx queue > > > information - event queue identifier, flags for handling received > > > packets, schedular type, event priority, polling frequency of the > > > receive queue and flow identifier in > > > rte_event_eth_rx_adapter_queue_info structure > > > > > > Signed-off-by: Ganapati Kundapura <ganapati.kundap...@intel.com> > > > > > > --- > > > v3: > > > * Split single patch into implementaion, test and document updation > > > patches separately > > > > > +struct rte_event_eth_rx_adapter_queue_info; > > > + > > > +/** > > > + * Retrieve information about Rx queue. This callback is invoked if > > > + * the caps returned from the eventdev_eth_rx_adapter_caps_get(, > > > +eth_port_id) > > > + * has RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT set. > > > > It will useful for !RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT case > > too. > >
Missed this comment in v4 > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h > > > b/lib/eventdev/rte_event_eth_rx_adapter.h > > > index 182dd2e..75c0010 100644 > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > > > @@ -33,6 +33,7 @@ > > > * - rte_event_eth_rx_adapter_stop() > > > * - rte_event_eth_rx_adapter_stats_get() > > > * - rte_event_eth_rx_adapter_stats_reset() > > > + * - rte_event_eth_rx_adapter_queue_info_get() > > > * > > > * The application creates an ethernet to event adapter using > > > * rte_event_eth_rx_adapter_create_ext() or > > > rte_event_eth_rx_adapter_create() @@ -140,6 +141,56 @@ typedef int > > (*rte_event_eth_rx_adapter_conf_cb) (uint8_t id, uint8_t dev_id, > > > void *arg); > > > > > > /** > > > + * Rx queue info > > > + */ > > > +struct rte_event_eth_rx_adapter_queue_info { > > > > Can we avoid the duplication of this structure and use > > rte_event_eth_rx_adapter_queue_conf instead. > > > > API can be rte_event_eth_rx_adapter_queue_conf_get() to align the > > structure. > > > > Also instead of every driver duplicating this code, How about > > - common code stores the config in > > rte_event_eth_rx_adapter_queue_add() > > - common code stores the config in > > rte_event_eth_rx_adapter_queue_conf_get() > > - Addtional PMD level API can be given incase, something needs to > > overridden by Adapter. Missed addressing this comment in v4.