On 8/27/2021 9:17 AM, Jie Wang wrote:
> The driver may change offloads info into dev->data->dev_conf
> in dev_configure which may cause port->dev_conf and port->rx_conf
> contain outdated values.
>
> This patch updates the offloads info if it changes to fix this issue.
>
> Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
>
> Signed-off-by: Jie Wang <[email protected]>
<...>
> + /* Apply Rx offloads configuration */
> + if (dev_conf_info.rxmode.offloads !=
> + port->dev_conf.rxmode.offloads) {
> + port->dev_conf.rxmode.offloads =
> + dev_conf_info.rxmode.offloads;
> + for (k = 0;
> + k < port->dev_info.max_rx_queues;
> + k++)
> + port->rx_conf[k].offloads =
> + dev_conf_info.rxmode.offloads;
If queue specific offloads are used, won't this overwrite it with port offload?
Should we get queue config from device and update queue offloads with it?
