On 9/14/2021 7:02 AM, Min Hu (Connor) wrote: > From: Huisong Li <lihuis...@huawei.com> > > This patch adds dev_close() step to release network adapter resources > when kni free. > > Signed-off-by: Huisong Li <lihuis...@huawei.com> > Signed-off-by: Min Hu (Connor) <humi...@huawei.com> > --- > examples/kni/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/examples/kni/main.c b/examples/kni/main.c > index beabb3c848..2a993a0ca4 100644 > --- a/examples/kni/main.c > +++ b/examples/kni/main.c > @@ -1031,6 +1031,7 @@ kni_free_kni(uint16_t port_id) > if (ret != 0) > RTE_LOG(ERR, APP, "Failed to stop port %d: %s\n", > port_id, rte_strerror(-ret)); > + rte_eth_dev_close(port_id); > > return 0; > } >
Acked-by: Ferruh Yigit <ferruh.yi...@intel.com> Closing the port not directly related to the 'kni free', just both done before exiting the app, so I would update the patch title to something like: examples/kni: close port before exit
