> Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels
>
> [You don't often get email from [email protected]. Learn
> why this is important at http://aka.ms/LearnAboutSenderIdentification.]
>
> On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel
> driver receives the request and opens the subchannels on PMDs behalf.
>
> Signed-off-by: Srikanth Kaka <[email protected]>
> Signed-off-by: Vag Singh <[email protected]>
> Signed-off-by: Anand Thulasiram <[email protected]>
> ---
> drivers/net/netvsc/hn_ethdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/netvsc/hn_ethdev.c
> b/drivers/net/netvsc/hn_ethdev.c index 9e2a405973..6f9053c4d5 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -515,6 +515,10 @@ static int hn_subchan_configure(struct hn_data *hv,
> if (err)
> return err;
>
> + err = rte_vmbus_ioctl(hv->vmbus, subchan);
> + if (err)
> + return err;
> +
Now I see why you return 0 for Linux. Can you add a comment to say this
function is not used and should always succeed in Linux?
> while (subchan > 0) {
> struct vmbus_channel *new_sc;
> uint16_t chn_index;
> --
> 2.30.2
