Acked-by: Hemant Agrawal <[email protected]> > -----Original Message----- > From: Xueming Li <[email protected]> > Sent: Wednesday, October 6, 2021 4:48 PM > To: [email protected] > Cc: [email protected]; Ferruh Yigit <[email protected]>; Andrew > Rybchenko <[email protected]>; Singh Aman Deep > <[email protected]>; Thomas Monjalon <[email protected]>; > John W. Linville <[email protected]>; Ciara Loftus > <[email protected]>; Qi Zhang <[email protected]>; Hemant > Agrawal <[email protected]>; Sachin Saxena (OSS) > <[email protected]>; Rosen Xu <[email protected]>; > Gagandeep Singh <[email protected]>; Bruce Richardson > <[email protected]>; Maxime Coquelin > <[email protected]>; Chenbo Xia <[email protected]> > Subject: [PATCH v7 1/2] ethdev: make queue release callback optional > Importance: High > > Some drivers don't need Rx and Tx queue release callback, make them > optional. Clean up empty queue release callbacks for some drivers. > > Signed-off-by: Xueming Li <[email protected]> > Reviewed-by: Andrew Rybchenko <[email protected]> > Acked-by: Ferruh Yigit <[email protected]> > Acked-by: Thomas Monjalon <[email protected]> > --- > app/test/virtual_pmd.c | 12 ---- > drivers/net/af_packet/rte_eth_af_packet.c | 7 -- > drivers/net/af_xdp/rte_eth_af_xdp.c | 7 -- > drivers/net/dpaa/dpaa_ethdev.c | 13 ---- > drivers/net/dpaa2/dpaa2_ethdev.c | 7 -- > drivers/net/ipn3ke/ipn3ke_representor.c | 12 ---- > drivers/net/kni/rte_eth_kni.c | 7 -- > drivers/net/pcap/pcap_ethdev.c | 7 -- > drivers/net/pfe/pfe_ethdev.c | 14 ---- > drivers/net/ring/rte_eth_ring.c | 4 -- > drivers/net/virtio/virtio_ethdev.c | 8 --- > lib/ethdev/rte_ethdev.c | 86 ++++++++++------------- > 12 files changed, 36 insertions(+), 148 deletions(-) > > diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index > 7036f401ed9..7e15b47eb0f 100644 > --- a/app/test/virtual_pmd.c > +++ b/app/test/virtual_pmd.c > @@ -163,16 +163,6 @@ virtual_ethdev_tx_queue_setup_fail(struct > rte_eth_dev *dev __rte_unused, > return -1; > } > > -static void > -virtual_ethdev_rx_queue_release(void *q __rte_unused) -{ -} > - > -static void > -virtual_ethdev_tx_queue_release(void *q __rte_unused) -{ -} > - > static int > virtual_ethdev_link_update_success(struct rte_eth_dev *bonded_eth_dev, > int wait_to_complete __rte_unused) > @@ -243,8 +233,6 @@ static const struct eth_dev_ops > virtual_ethdev_default_dev_ops = { > .dev_infos_get = virtual_ethdev_info_get, > .rx_queue_setup = virtual_ethdev_rx_queue_setup_success, > .tx_queue_setup = virtual_ethdev_tx_queue_setup_success, > - .rx_queue_release = virtual_ethdev_rx_queue_release, > - .tx_queue_release = virtual_ethdev_tx_queue_release, > .link_update = virtual_ethdev_link_update_success, > .mac_addr_set = virtual_ethdev_mac_address_set, > .stats_get = virtual_ethdev_stats_get, diff --git > a/drivers/net/af_packet/rte_eth_af_packet.c > b/drivers/net/af_packet/rte_eth_af_packet.c > index fcd80903995..c73d2ec5c86 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -427,11 +427,6 @@ eth_dev_close(struct rte_eth_dev *dev) > return 0; > } > > -static void > -eth_queue_release(void *q __rte_unused) -{ -} > - > static int > eth_link_update(struct rte_eth_dev *dev __rte_unused, > int wait_to_complete __rte_unused) @@ -594,8 +589,6 @@ static > const struct eth_dev_ops ops = { > .promiscuous_disable = eth_dev_promiscuous_disable, > .rx_queue_setup = eth_rx_queue_setup, > .tx_queue_setup = eth_tx_queue_setup, > - .rx_queue_release = eth_queue_release, > - .tx_queue_release = eth_queue_release, > .link_update = eth_link_update, > .stats_get = eth_stats_get, > .stats_reset = eth_stats_reset, > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > index 9bea0a895a3..a619dd218d0 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -989,11 +989,6 @@ eth_dev_close(struct rte_eth_dev *dev) > return 0; > } > > -static void > -eth_queue_release(void *q __rte_unused) -{ -} > - > static int > eth_link_update(struct rte_eth_dev *dev __rte_unused, > int wait_to_complete __rte_unused) > @@ -1474,8 +1469,6 @@ static const struct eth_dev_ops ops = { > .promiscuous_disable = eth_dev_promiscuous_disable, > .rx_queue_setup = eth_rx_queue_setup, > .tx_queue_setup = eth_tx_queue_setup, > - .rx_queue_release = eth_queue_release, > - .tx_queue_release = eth_queue_release, > .link_update = eth_link_update, > .stats_get = eth_stats_get, > .stats_reset = eth_stats_reset, > diff --git a/drivers/net/dpaa/dpaa_ethdev.c > b/drivers/net/dpaa/dpaa_ethdev.c index 36d8f9249df..2c12956ff6b 100644 > --- a/drivers/net/dpaa/dpaa_ethdev.c > +++ b/drivers/net/dpaa/dpaa_ethdev.c > @@ -1233,12 +1233,6 @@ dpaa_eth_eventq_detach(const struct > rte_eth_dev *dev, > return 0; > } > > -static > -void dpaa_eth_rx_queue_release(void *rxq __rte_unused) -{ > - PMD_INIT_FUNC_TRACE(); > -} > - > static > int dpaa_eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, > uint16_t nb_desc __rte_unused, > @@ -1272,11 +1266,6 @@ int dpaa_eth_tx_queue_setup(struct rte_eth_dev > *dev, uint16_t queue_idx, > return 0; > } > > -static void dpaa_eth_tx_queue_release(void *txq __rte_unused) -{ > - PMD_INIT_FUNC_TRACE(); > -} > - > static uint32_t > dpaa_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id) > { @@ -1571,8 +1560,6 @@ static struct eth_dev_ops dpaa_devops = { > > .rx_queue_setup = dpaa_eth_rx_queue_setup, > .tx_queue_setup = dpaa_eth_tx_queue_setup, > - .rx_queue_release = dpaa_eth_rx_queue_release, > - .tx_queue_release = dpaa_eth_tx_queue_release, > .rx_burst_mode_get = dpaa_dev_rx_burst_mode_get, > .tx_burst_mode_get = dpaa_dev_tx_burst_mode_get, > .rxq_info_get = dpaa_rxq_info_get, > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c > b/drivers/net/dpaa2/dpaa2_ethdev.c > index c12169578e2..48ffbf6c214 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -1004,12 +1004,6 @@ dpaa2_dev_rx_queue_release(void *q > __rte_unused) > } > } > > -static void > -dpaa2_dev_tx_queue_release(void *q __rte_unused) -{ > - PMD_INIT_FUNC_TRACE(); > -} > - > static uint32_t > dpaa2_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id) > { @@ -2427,7 +2421,6 @@ static struct eth_dev_ops dpaa2_ethdev_ops = { > .rx_queue_setup = dpaa2_dev_rx_queue_setup, > .rx_queue_release = dpaa2_dev_rx_queue_release, > .tx_queue_setup = dpaa2_dev_tx_queue_setup, > - .tx_queue_release = dpaa2_dev_tx_queue_release, > .rx_burst_mode_get = dpaa2_dev_rx_burst_mode_get, > .tx_burst_mode_get = dpaa2_dev_tx_burst_mode_get, > .flow_ctrl_get = dpaa2_flow_ctrl_get, [Hemant]
Acked-by: Hemant Agrawal <[email protected]>
