> -----Original Message----- > From: Guo, Junfeng <[email protected]> > Sent: Wednesday, September 29, 2021 8:32 PM > To: Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; > Xing, Beilei <[email protected]> > Cc: [email protected]; [email protected]; Yigit, Ferruh <[email protected]>; > Guo, Junfeng <[email protected]>; Liu, Lingyu <[email protected]> > Subject: [PATCH v2] net/iavf: fix QFI field bit check for GTPU EH > > If GTPU Extionsion header has no pdu_type setting, the parsed value of > gtp_psc_spec->pdu_type will be 0, which is same as IAVF_GTPU_EH_DWLINK. > Thus, for this case, we should check gtp_psc_mask->pdu_type instead, to set > QFI field bit of GTPU_EH first. > > Fixes: 45cc3a5435fc ("net/iavf: fix QFI fields of GTPU UL/DL for FDIR") > Cc: [email protected] > > Signed-off-by: Junfeng Guo <[email protected]>
The patch can't be applied due to below commit commit 16b8e92d49b87705fffbedd9c3241204d9a584a6 Author: Raslan Darawsheh <[email protected]> Date: Mon Aug 23 13:55:39 2021 +0300 ethdev: use extension header for GTP PSC item This updates the gtp_psc flow item to use the net header definition of the gtp_psc to be based on RFC 38415-g30 Signed-off-by: Raslan Darawsheh <[email protected]> Acked-by: Ferruh Yigit <[email protected]> Could you rebase? Thanks Qi > --- > drivers/net/iavf/iavf_fdir.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index > 560589a496..227a089ce0 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -1171,17 +1171,15 @@ iavf_fdir_parse_pattern(__rte_unused struct > iavf_adapter *ad, > if (gtp_psc_spec && gtp_psc_mask) { > if (gtp_psc_mask->qfi == UINT8_MAX) { > input_set |= IAVF_INSET_GTPU_QFI; > - if (gtp_psc_spec->pdu_type == > - > IAVF_GTPU_EH_UPLINK) > + if (!gtp_psc_mask->pdu_type) > > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, > - > GTPU_UP, QFI); > - else if (gtp_psc_spec->pdu_type == > - > IAVF_GTPU_EH_DWLINK) > + > GTPU_EH, QFI); > + else if (gtp_psc_spec->pdu_type == > IAVF_GTPU_EH_DWLINK) > > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, > > GTPU_DWN, QFI); > - else > + else if (gtp_psc_spec->pdu_type == > IAVF_GTPU_EH_UPLINK) > > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, > - > GTPU_EH, QFI); > + > GTPU_UP, QFI); > } > > rte_memcpy(hdr->buffer, gtp_psc_spec, > -- > 2.25.1
