07/10/2021 12:20, Andrew Rybchenko: > On 10/6/21 12:56 AM, Thomas Monjalon wrote: > > 13/09/2021 13:26, Andrew Rybchenko: > >> From: Viacheslav Galaktionov <viacheslav.galaktio...@oktetlabs.ru> > >> > >> Getting a list of representors from a representor does not make sense. > >> Instead, a parent device should be used. > > > > I don't understand which issue it is fixing. > > This function was not working before if not using the backer port? > > The function, rte_eth_representor_id_get(), is used in > eth_representor_cmp() which is required in ethdev class > iterator to search ethdev port ID by name (representor case). > Before the patch the function is called on the representor > itself it tries to get representors info to match. > > It was found by OvS+DPDK testing: > 1. OvS hotplugs representor > 2. OvS tries to find DPDK port ID for just hotplugged > representor and fails (if PMD does not provider > representors info on the representor itself) > > > Is it fixing a specific PMD? > > It is a generic fix for PMD which do *not* provide representors > info on the representor itself.
This is the key information. Please reword the commit log.
