Re: [dpdk-dev] [PATCH v2 3/3] security: add reserved bitfields

[Kinsella, Ray]

On 08/10/2021 21:45, Akhil Goyal wrote:
> In struct rte_security_ipsec_sa_options, for every new option
> added, there is an ABI breakage, to avoid, a reserved_opts
> bitfield is added to for the remaining bits available in the
> structure.
> Now for every new sa option, these reserved_opts can be reduced
> and new option can be added.
> 
> Signed-off-by: Akhil Goyal <gak...@marvell.com>
> Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com>
> ---
> v2: rebase and removed libabigail.abignore change.
>     Exception may be added when there is a need for change.
> 
>  lib/security/rte_security.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h
> index 7eb9f109ae..c0ea13892e 100644
> --- a/lib/security/rte_security.h
> +++ b/lib/security/rte_security.h
> @@ -258,6 +258,12 @@ struct rte_security_ipsec_sa_options {
>        * PKT_TX_UDP_CKSUM or PKT_TX_L4_MASK in mbuf.
>        */
>       uint32_t l4_csum_enable : 1;
> +
> +     /** Reserved bit fields for future extension
> +      *
> +      * Note: reduce number of bits in reserved_opts for every new option
> +      */
> +     uint32_t reserved_opts : 18;
>  };
>  
>  /** IPSec security association direction */
> 
Acked-by: Ray Kinsella <m...@ashroe.eu>