Hello, > [...] > As you probably noticed, I merged John patch. > Could you rebase this series on the main branch please?
Of course. Only would you accept that for now I'll just keep the tests John has added? With the new helper, directory selection logic can be tested isolated from parsing and mkdir(), but we have little time until RC1. Tests can be improved anytime. > [...] > We are in a rather generic helper function. > Error messages should be logged by callers of this helper, because the > caller knows better what the impact of failing to list mountpoints is. > In the helper itself, this log should probably be info or debug level. > > If you think this error-level log should be kept in the helper, can you > make it a bit higher level so that users understand what is wrong and what > actions should be done to fix the situation? No, I agree that DEBUG is better for system errors. I don't often add generic code, but for Windos we log all system errors as DEBUG and higher-level as ERR. Will send v7, thanks.
