On Thu, Oct 14, 2021 at 10:55 AM Dmitry Kozlyuk <[email protected]> wrote:
>
> MLX5 PMD exposes a socket for external tools to dump port state.
> Socket events are listened using an interrupt source of EXT type.
> The socket was closed and the interrupt callback was unregistered
> at program exit, which is incorrect because DPDK could be already
> shut down at this point. Move actions performed at program exit
> to the moment the last MLX5 port is closed. The socket will be opened
> again if later a new MLX5 device is plugged in and probed.
> Also fix comments that were deceisively talking
> about secondary processes instead of external tools.
+1 for fixing those comments.
>
> Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
> Cc: Xueming Li <[email protected]>
> Cc: [email protected]
>
> Reported-by: Harman Kalra <[email protected]>
> Signed-off-by: Dmitry Kozlyuk <[email protected]>
> Acked-by: Thomas Monjalon <[email protected]>
The fix lgtm, thanks.
There is a separate issue I spotted while reviewing.
I'll send a separate fix.
--
David Marchand
