On 10/19/21 4:42 PM, David Marchand wrote:
On Mon, Oct 18, 2021 at 10:37 AM Andrew Rybchenko
<[email protected]> wrote:
diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index 88bcbc51ef..d2bf2843f7 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -258,6 +258,15 @@ struct rte_mempool {
#define MEMPOOL_F_POOL_CREATED 0x0010 /**< Internal: pool is created. */
#define MEMPOOL_F_NO_IOVA_CONTIG 0x0020 /**< Don't need IOVA contiguous objs.
*/
+/**
+ * This macro lists all the mempool flags an application may request.
+ */
+#define MEMPOOL_VALID_USER_FLAGS (MEMPOOL_F_NO_SPREAD \
I think RTE_ prefix is missing here since it is in a public
header now.
+ | MEMPOOL_F_NO_CACHE_ALIGN \
+ | MEMPOOL_F_SP_PUT \
+ | MEMPOOL_F_SC_GET \
+ | MEMPOOL_F_NO_IOVA_CONTIG \
+ )
/**
* @internal When debug is enabled, store some statistics.
*
Should we make a patch to add defines with RTE_ prefix and
add a deprecation for old flags without RTE_ prefix?
Olivier, what do you think? If you have time to care about it,
it would be great. (I'm unfamiliar with coccinelle yet).
Andrew,
RTE_ prefixing subject put aside, are you ok with this patch?
Yes,
Acked-by: Andrew Rybchenko <[email protected]>
