> -----Original Message----- > From: Tudor Cornea <[email protected]> > Sent: Thursday, October 21, 2021 02:14 > To: Zhang, Qi Z <[email protected]> > Cc: Wang, Haiyue <[email protected]>; Zhang, AlvinX > <[email protected]>; Yigit, Ferruh > <[email protected]>; [email protected]; Tudor Cornea <[email protected]> > Subject: [PATCH v2] net/ixgbe: initialize port even if mtu config fails > > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't > seem to initialize anymore, while running testpmd. > > Configuring Port 0 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 0: Invalid argument > Configuring Port 1 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 1: Invalid argument > Please stop the ports first > > If the call to ixgbevf_rlpml_set_vf fails and we return prematurely, > we will not be able to initialize the ports correctly. > > The behavior seems to have changed since the following commit: > > commit c77866a16904 ("net/ixgbe: detect failed VF MTU set") > > We can make this particular use case work correctly if we don't > return an error, which seems to be consistent with the overall > kernel ixgbevf implementation. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ixg > bevf/ixgbevf_main.c#n2015 > > Signed-off-by: Tudor Cornea <[email protected]> > > --- > v2: > * Change title > * Remove max_rx_pkt_len fix in ixgbe_ethdev.c > It's already fixed as part of Ferruh's changes in next-net branch, > so this part should be redundant, now > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >
Thanks! Acked-by: Haiyue Wang <[email protected]> > -- > 2.7.4
