On 10/21/21 11:28 AM, Wang, Jie1X wrote:
> 
> 
>> -----Original Message-----
>> From: Andrew Rybchenko <[email protected]>
>> Sent: Thursday, October 21, 2021 3:53 PM
>> To: Wang, Jie1X <[email protected]>; [email protected]
>> Cc: Yigit, Ferruh <[email protected]>; NBU-Contact-Thomas Monjalon
>> <[email protected]>; Li, Xiaoyun <[email protected]>; Yang, SteveX
>> <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei
>> <[email protected]>; Wu, Wenjun1 <[email protected]>; Zhang, Qi Z
>> <[email protected]>; Ori Kam <[email protected]>
>> Subject: Re: [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol
>>
>> On 10/21/21 10:50 AM, Ori Kam wrote:
>>> Hi Jie,
>>>
>>>> -----Original Message-----
>>>> From: Jie Wang <[email protected]>
>>>> Sent: Thursday, October 21, 2021 9:26 AM
>>>> Subject: [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol
>>>>
>>>> Added flow pattern items and header formats of L2TPv2 and PPP.
>>>>
>>>> Signed-off-by: Wenjun Wu <[email protected]>
>>>> Signed-off-by: Jie Wang <[email protected]>
>>
>> [snip]
>>
>>>> diff --git a/doc/guides/nics/features/iavf.ini
>> b/doc/guides/nics/features/iavf.ini
>>>> index d00ca934c3..a916275b88 100644
>>>> --- a/doc/guides/nics/features/iavf.ini
>>>> +++ b/doc/guides/nics/features/iavf.ini
>>>> @@ -50,8 +50,10 @@ icmp6                = Y
>>>>  ipv4                 = Y
>>>>  ipv6                 = Y
>>>>  ipv6_frag_ext        = Y
>>>> +l2tpv2               = Y
>>>>  l2tpv3oip            = Y
>>>>  pfcp                 = Y
>>>> +ppp                  = Y
>>
>> It must be added in the patch when driver support is added.
>>
> 
> Hi Andrew,
> 
> I don't understand what you're saying. Could you describe it in more detail?

The patch is an ethdev patch which defines the feature.
When just the patch is applied, the driver iavf does not
support it yet. Support is added in a later patch of the
patch series. So, you should claim support in the driver
when support is actually added.

> 
>>>>  sctp                 = Y
>>>>  tcp                  = Y
>>>>  udp                  = Y
>>
>> [snip]

Reply via email to