On 10/22/2021 3:10 PM, Jiang, YuX wrote:
-----Original Message----- From: dev <[email protected]> On Behalf Of Ferruh Yigit Sent: 2021年10月22日 20:57 To: Wang, Haiyue <[email protected]>; Xing, Beilei <[email protected]>; Wu, Jingjing <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Hyong Youb Kim <[email protected]>; Michal Krawczyk <[email protected]>; Andrew Rybchenko <[email protected]>; Somnath Kotur <[email protected]> Cc: Yigit, Ferruh <[email protected]>; [email protected] Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flagAfter DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo frame decisions based on MTU value checks, but some of the checks were wrong by mistake, causing device initialization to fail, fixing them. Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") Signed-off-by: Ferruh Yigit <[email protected]>Tested-by: Yu Jiang <[email protected]> Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/[email protected]/ on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable) Tested on i40e(iavf) and it looks good, will test more on others.
Thanks Yu, I can see it is not fully validated, and most likely it won't be before -rc1, but it would be good to have this fix for -rc1 to not block testing. Since the previous code is clearly wrong, and fixes are similar between drivers, if one is good I will take risk and merge the fix for -rc1.
