> > Hi, I reworked this patch as part of a new patchset, and some comments > below. > > On the comment about the offload capabilities, i.e. what happens if a > PMD supports SECURITY and TSO but not both in the same time, well, if > this is the case they should not be set both,
Ok, let' take an existing PMD: ixgbe. It supports both IPSEC and TSO offloads. Would IPSEC+TSO work with current ixgbe PMD? > and also this can > theoretically happen with any offloads combinations. Hmm... can you provide an example with any DPDK PMD when offloads are supported in separate, but their combination doesn't?