On Wed, Oct 27, 2021 at 7:09 PM Kalesh A P <kalesh-anakkur.pura...@broadcom.com> wrote: > > From: Kalesh AP <kalesh-anakkur.pura...@broadcom.com> > > With commit 239695f754cb ("net/bnxt: enhance RSS action support"), > when bnxt_hwrm_vnic_rss_cfg() call fails, driver was not setting > flow error using "rte_flow_error_set". > > Fixes: 239695f754cb ("net/bnxt: enhance RSS action support") > > Signed-off-by: Kalesh AP <kalesh-anakkur.pura...@broadcom.com> > Reviewed-by: Ajit Khaparde <ajit.khapa...@broadcom.com> > Reviewed-by: Somnath Kotur <somnath.ko...@broadcom.com> Patch applied to dpdk-next-net-brcm. Thanks
> --- > drivers/net/bnxt/bnxt_flow.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index 9526a8f..b3c68b1 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -1226,6 +1226,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, > > skip_rss_table: > rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); > + if (rc != 0) { > + rte_flow_error_set(error, > + -rc, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, > + "VNIC RSS configure failed"); > + rc = -rte_errno; > + goto ret; > + } > ret: > return rc; > } > @@ -1515,7 +1524,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev, > /* RSS config update requested */ > rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error); > if (rc != 0) > - return -rte_errno; > + goto ret; > > filter->dst_id = vnic->fw_vnic_id; > break; > -- > 2.10.1 >