28/10/2021 12:22, Ferruh Yigit: > On 10/28/2021 9:34 AM, Thomas Monjalon wrote: > > The port ownership concept was introduced in ethdev in DPDK 18.02. > > Not sure it is used by applications except those using failsafe or netvsc. > > It can also be used by libraries or applications to sort out > > how ports are controlled. > > > > Hiding sub-ports controlled by failsafe or netvsc look to be enough > > justification to promote this API as stable. > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > There is a defect in the 'rte_eth_dev_owner_delete()', which cause a crash, > it is fixed in my ethdev unit test patch: > https://patches.dpdk.org/project/dpdk/patch/20210716142800.3853651-8-ferruh.yi...@intel.com/ > > I think we should get the fix first.
I think such fix should be sent separately. OK to get the fix first. > And the crash not detected/reported until now makes me think API is still > not used much, I wonder if we should wait a little more to mature them. It is not a surprise that the delete operation is not used much. But the set operation is used. I am not sure about waiting more. I have no strong opinion. > Also only internal user of the API is 'drivers/net/netvsc', I wonder if > PMD detect the crash? Question for Long Li?
