Hi Pablo,

Verified with updated test vector.  the output did not change from previous 
output but also, it did not match the ouput present in the vector.

Regards
Sagar

________________________________
From: De Lara Guarch, Pablo <[email protected]>
Sent: 01 November 2021 03:36
To: Vidya Sagar Velumuri <[email protected]>; Ankur Dwivedi 
<[email protected]>; Anoob Joseph <[email protected]>; Tejasree Kondoj 
<[email protected]>; Nithin Kumar Dabilpuram <[email protected]>; 
Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: [email protected] <[email protected]>
Subject: [EXT] RE: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 
256 bit key

External Email
________________________________

Hi Sagar,



Thanks for flagging this. I submitted a patch fixing the IV of the test vectors 
I pushed (it didn’t change the output):

http://patches.dpdk.org/project/dpdk/patch/[email protected]/<https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.org_project_dpdk_patch_20211031220421.52181-2D1-2Dpablo.de.lara.guarch-40intel.com_&d=DwMFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=9VCCg7VNdg-jfzaFw1fN59x7Py9yM-ofwvekNj6MPxM&m=2eElny5n4QewacnppQimeCdeyB6B6GXxfdF4oet4KAlTXpwgcfhUF0Z3q2Ph4evt&s=pputaMk4g9cVhsjiJ1euKMLuGx24bIVTDh0AA4WrKwI&e=>



Could you check if they work for you?



Thanks,

Pablo



From: Vidya Sagar Velumuri <[email protected]>
Sent: Saturday, October 30, 2021 1:26 PM
To: De Lara Guarch, Pablo <[email protected]>; Ankur Dwivedi 
<[email protected]>; Anoob Joseph <[email protected]>; Tejasree Kondoj 
<[email protected]>; Nithin Kumar Dabilpuram <[email protected]>; 
Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 
bit key



Hi Pablo,



Tried the test vector zuc256_test_case_auth_1 and the digest did not match with 
the generated digest in our platform.



As per spec, IV[i] for i = 17 to 24 are 6-bit string occupying the 6 least 
signi cant bits of a byte.

But in the vectors, The values in the IV(byte -17 to 24) are > 0x3f.



Could you please elaborate how these bytes are considered for generation of 
digest.



Regards

Sagar



________________________________

From: De Lara Guarch, Pablo 
<[email protected]<mailto:[email protected]>>
Sent: 29 October 2021 18:07
To: Vidya Sagar Velumuri <[email protected]<mailto:[email protected]>>; 
Ankur Dwivedi <[email protected]<mailto:[email protected]>>; Anoob Joseph 
<[email protected]<mailto:[email protected]>>; Tejasree Kondoj 
<[email protected]<mailto:[email protected]>>; Nithin Kumar Dabilpuram 
<[email protected]<mailto:[email protected]>>; Akhil Goyal 
<[email protected]<mailto:[email protected]>>; Doherty, Declan 
<[email protected]<mailto:[email protected]>>
Cc: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>
Subject: [EXT] RE: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 
256 bit key



External Email

----------------------------------------------------------------------
Hi Vidya,

> -----Original Message-----
> From: dev <[email protected]<mailto:[email protected]>> On Behalf Of 
> Vidya Sagar Velumuri
> Sent: Wednesday, October 27, 2021 9:41 AM
> To: [email protected]<mailto:[email protected]>; 
> [email protected]<mailto:[email protected]>; 
> [email protected]<mailto:[email protected]>;
> [email protected]<mailto:[email protected]>; 
> [email protected]<mailto:[email protected]>; Doherty, Declan
> <[email protected]<mailto:[email protected]>>
> Cc: [email protected]<mailto:[email protected]>
> Subject: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit 
> key
>
> Fix the IV and MAC in the test vectors added for zuc 256-bit key
>
> Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys)
>
> Signed-off-by: Vidya Sagar Velumuri 
> <[email protected]<mailto:[email protected]>>

The new vectors are failing for us. Could you check if the ones we added work 
for you?

Thanks,
Pablo

Reply via email to