Hi Anoob, > -----Original Message----- > From: Power, Ciara <[email protected]> > Sent: Wednesday, November 10, 2021 5:01 PM > To: Anoob Joseph <[email protected]>; Akhil Goyal <[email protected]>; > Doherty, Declan <[email protected]>; Zhang, Roy Fan > <[email protected]>; De Lara Guarch, Pablo > <[email protected]> > Cc: Jerin Jacob <[email protected]>; Archana Muniganti > <[email protected]>; Tejasree Kondoj <[email protected]>; Hemant > Agrawal <[email protected]>; Nicolau, Radu > <[email protected]>; Gagandeep Singh <[email protected]>; Ji, Kai > <[email protected]>; [email protected]; [email protected]; De Lara > Guarch, Pablo <[email protected]> > Subject: RE: [PATCH v2] test/crypto: skip plain text compare for null cipher > > Hi Anoob, > > >-----Original Message----- > >From: Anoob Joseph <[email protected]> > >Sent: Wednesday 10 November 2021 13:04 > >To: Akhil Goyal <[email protected]>; Doherty, Declan > ><[email protected]>; Zhang, Roy Fan <[email protected]>; > >De Lara Guarch, Pablo <[email protected]> > >Cc: Anoob Joseph <[email protected]>; Jerin Jacob > ><[email protected]>; Archana Muniganti <[email protected]>; > >Tejasree Kondoj <[email protected]>; Hemant Agrawal > ><[email protected]>; Nicolau, Radu <[email protected]>; > >Power, Ciara <[email protected]>; Gagandeep Singh > ><[email protected]>; Ji, Kai <[email protected]>; [email protected]; > >[email protected] > >Subject: [PATCH v2] test/crypto: skip plain text compare for null > >cipher > > > >NULL cipher is used for validating auth only cases. With NULL cipher, > >validating plain text should not be done as the PMD is only expected to > >update auth data. > > > >Fixes: e847fc512817 ("test/crypto: add encrypted digest case for > >AES-CTR- > >CMAC") > >Cc: [email protected] > > > >Signed-off-by: Anoob Joseph <[email protected]> > >--- > >Changes in v2: > >- Made the skip applicable for in place also (comment from Pablo) > >- Re-organized code as suggested by Pablo > >- Made same change in test_mixed_auth_cipher_sgl (comment from Pablo) > > > > app/test/test_cryptodev.c | 63 > > ++++++++++++++++++++++++++-------------- > > Acked-by: Ciara Power <[email protected]>
Wonder if this patch needs to CC stable, as it's fixing a commit from 2019? Apart from this: Acked-by: Pablo de Lara <[email protected]>
