26/11/2021 13:53, Ferruh Yigit: > On 11/26/2021 9:51 AM, Viacheslav Ovsiienko wrote: > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > > introduced by [1]. This action provides an unified way > > to perform various arithmetic and transfer operations over > > packet network header fields and packet metadata. > > > > [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow action") > > > > On other side there are a bunch of multiple legacy actions, > > that can be superseded by the generic MODIFY_FIELD action: > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL sfc > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC bnxt, cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST bnxt, cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_TP_DST cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_DEC_TTL mlx5, sfc > > RTE_FLOW_ACTION_TYPE_SET_TTL mlx5 > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ mlx5 > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ mlx5 > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK mlx5 > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP mlx5 > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID bnxt, cnxk, cxgbe, enic, > > mlx5, octeontx2, sfc > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP bnxt, cnxk, cxgbe, enic, > > mlx5, octeontx2, sfc > > RTE_FLOW_ACTION_TYPE_SET_TAG mlx5 > > RTE_FLOW_ACTION_TYPE_SET_META mlx5 > > > > This note deprecates the following RTE Flow actions, > > as not supported by any of PMDs: > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > > > The following actions are supposed to be deprecated in 22.07 > > and replaced by generic field modify action: > > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC > > RTE_FLOW_ACTION_TYPE_SET_TP_DST > > RTE_FLOW_ACTION_TYPE_DEC_TTL > > RTE_FLOW_ACTION_TYPE_SET_TTL > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > RTE_FLOW_ACTION_TYPE_SET_TAG > > RTE_FLOW_ACTION_TYPE_SET_META > > > > The VLAN set actions are interrelated to VLAN header insertion/removal > > and supported by multiple PMDs and widely used by applications and > > not supposed to be deprecated due to potential large impact on > > drivers and applications. > > > > Signed-off-by: Viacheslav Ovsiienko<viachesl...@nvidia.com> > > Thanks for the update, > Acked-by: Ferruh Yigit <ferruh.yi...@intel.com> > > > We need to follow with relevant PMD maintainers to switch to new > 'MODIFY_FIELD' action till end of v22.07 release.
Yes I would like to see them replying here, but seems some are not watching. I don't want to block this interesting deprecation plan, so I will merge if few more maintainers involved in ethdev give their ack. Acked-by: Thomas Monjalon <tho...@monjalon.net>