> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Thursday, March 12, 2015 9:17 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow > > This series contains some bug fixes that were found during my work on the > ixgbe LRO > patches. Sending this series separately on Thomas request so that it may be > integrated > into the 2.0 release. > > New in v3: > - Adjusted to the new structs naming in the master. > - Fixed rx_bulk_alloc_allowed and rx_vec_allowed initialization: > - Don't set them to FALSE in rte_eth_dev_stop() flow - the following > rte_eth_dev_start() will need them. > - Reset them to TRUE in rte_eth_dev_configure() and not in a probe() > flow. > This will ensure the proper behaviour if port is re-configured. > - Rename: > - ixgbe_rx_vec_condition_check() -> > ixgbe_rx_vec_dev_conf_condition_check() > - set_rx_function() -> ixgbe_set_rx_function() > - Clean up the logic in ixgbe_set_rx_function(). > - Define stubs with __attribute__((weak)) instead of using #ifdef's. > - Styling: beautify ixgbe_rxtx.h a bit. > > New in v2: > - Fixed a compilation failure. > > > Vlad Zolotarov (3): > ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when > reading/setting HW ring descriptor fields > ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices > ixgbe: Unify the rx_pkt_bulk callback initialization > > lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 + > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 13 +- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 216 > +++++++++++++++++++++----------- > lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 28 ++++- > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- > 5 files changed, 183 insertions(+), 78 deletions(-) >
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com> Just one nit: +int __attribute__((weak)) ixgbe_rxq_vec_setup( + struct ixgbe_rx_queue __rte_unused *rxq) +{ Please use notation: int __attribute__((weak)) ixgbe_rxq_vec_setup(struct ixgbe_rx_queue __rte_unused *rxq) To keep up with the rest of the code, plus makes much easier to read. > -- > 2.1.0