On Wed, Feb 9, 2022 at 2:38 PM Thomas Monjalon <tho...@monjalon.net> wrote:
>
> 08/02/2022 16:08, Aaron Conole:
> > Thomas Monjalon <tho...@monjalon.net> writes:
> >
> > > The variable REF_GIT_TAG is set in the CI configuration
> > > like .travis.yml or .github/workflows/build.yml.
> > > The default value is outdated and probably unused.
> > > It is removed completely to avoid forgetting an update in future.
> > >
> > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> > > ---
> >
> > I think the default was there for labs that run the build script
> > manually. Maybe there are no such users, though. I believe the lab has
> > its own script for doing such ABI checks (but can't remember off the top
> > of my head).
> >
> > CC'd Lincoln and Owen just to confirm.
> >
> > Assuming the UNH/other lab doesn't use this feature of the linux build
> > script,
> >
> > Acked-by: Aaron Conole <acon...@redhat.com>
>
> I could also remove this variable:
> LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6}
>
> It is confusing to see an old version here,
> while we use the version 1.8.
>
> If no objection, I'll send a v2.
+1.
--
David Marchand
