> -----Original Message----- > From: Yunjian Wang <[email protected]> > Sent: Tuesday, February 15, 2022 18:25 > To: [email protected] > Cc: Yigit, Ferruh <[email protected]>; Wu, Jingjing > <[email protected]>; Xing, Beilei > <[email protected]>; Wang, Haiyue <[email protected]>; > [email protected]; > [email protected]; [email protected]; [email protected]; > Yunjian Wang > <[email protected]>; [email protected] > Subject: [dpdk-dev] [PATCH 3/3] net/iavf: set pointer to NULL after free > > When iavf_security_ctx_destroy() is cleaning up, it does not correctly > set the security_ctx variable to NULL, which will lead to wild pointer. > > Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") > Cc: [email protected] > > Signed-off-by: Yunjian Wang <[email protected]> > --- > drivers/net/iavf/iavf_ipsec_crypto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c > b/drivers/net/iavf/iavf_ipsec_crypto.c > index 6ac1b213db..f13849ca1c 100644 > --- a/drivers/net/iavf/iavf_ipsec_crypto.c > +++ b/drivers/net/iavf/iavf_ipsec_crypto.c > @@ -1555,6 +1555,7 @@ iavf_security_ctx_destroy(struct iavf_adapter *adapter) > > iavf_sctx = NULL; > sctx = NULL;
The above two lines can be removed, since it is local var. > + adapter->vf.eth_dev->security_ctx = NULL; Also, adapter->security_ctx = NULL ? > > return 0; > } > -- > 2.27.0
