> -----Original Message-----
> From: Ferruh Yigit <[email protected]>
> Sent: Friday, March 4, 2022 4:46 PM
> To: Vamsi Krishna Attunuru <[email protected]>; [email protected]
> Cc: Jerin Jacob Kollanukkaran <[email protected]>; Nithin Kumar
> Dabilpuram <[email protected]>; [email protected];
> [email protected]; Wei Ling <[email protected]>; Srikanth Yalavarthi
> <[email protected]>
> Subject: Re: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion
> failure
>
> On 3/4/2022 10:20 AM, Vamsi Krishna Attunuru wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <[email protected]>
> >> Sent: Thursday, March 3, 2022 10:52 PM
> >> To: Vamsi Krishna Attunuru <[email protected]>; [email protected]
> >> Cc: Jerin Jacob Kollanukkaran <[email protected]>; Nithin Kumar
> >> Dabilpuram <[email protected]>; [email protected];
> >> [email protected]; Wei Ling <[email protected]>; Srikanth Yalavarthi
> >> <[email protected]>
> >> Subject: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion
> >> failure
> >>
> >> External Email
> >>
> >> ---------------------------------------------------------------------
> >> - On 3/2/2022 1:46 PM, Vamsi Attunuru wrote:
> >>> Use dynamically allocated memory for storing soft expiry ring base
> >>> addresses which fixes the static assertion failure, as the size of
> >>> dynamic allocation depends on RTE_MAX_ETHPORTS which varies based
> on
> >>> the build config.
> >>>
> >>
> >> Hi Vamsi,
> >>
> >> "fix static assertion failure" is not enough descriptive.
> >> assertions already added to verify assumptions, and in this case it
> >> seems it failed, but what was actually wrong?
> >>
> >> Is it that allocated memory size for ring wrong? (this is what I got
> >> from commit log but I am not sure)
> >>
> >> Can you please describe what actually was wrong and fixed now?
> >>
> > Hi Ferruh,
> >
> > Earlier sa_soft_exp_ring struct member was an array of pointers and
> > it's size is linked to num RTE_MAX_ETHPORTS, and the whole struct size
> > is confined and protected by size assertion. It resulted in build failure
> > with -
> Dmax_ethports=1024 option and assertion caught that failure. V2 fixes the
> issues by allocating the required memory dynamically instead
> > of using array of pointers.
> >
>
> Thanks Vamsi for details,
>
> I was expecting a new version of patch with updated commit log, but to
> make patch for -rc3 I will update it in next-net according above information
Sure, thanks Ferruh.
>
> >>> Bugzilla ID: 940
> >>> Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry
> >>> notification") Cc:[email protected]
> >>>
> >>> Reported-by: Wei Ling<[email protected]>
> >>> Reported-by: Yu Jiang<[email protected]>
> >>> Signed-off-by: Vamsi Attunuru<[email protected]>
> >>> Signed-off-by: Srikanth Yalavarthi<[email protected]>
> >>> ---
> >>> V2: Add bugzilla & reportee details, remove unused changes.
> >>> ---
> >
