Hi Thomas, > -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: Tuesday, March 8, 2022 06:30 > To: Zhang, Tianfei <[email protected]>; Huang, Wei > <[email protected]> > Cc: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z > <[email protected]>; [email protected]; [email protected]; > [email protected]; Yigit, Ferruh <[email protected]> > Subject: Re: [PATCH v1] raw/ifpga: fix monitor thread issues > > 01/03/2022 09:47, Wei Huang: > > Monitor thread handles graceful shutdown according to the value of > > specific sensors in device, two issues are found below. > > 1. Thread is not created when card is probed. > > 2. Thread is canceled without checking presence of other cards. > > To fix them, thread is created in pci device probe function, a > > reference count is checked before canceling the thread. > > > > Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") > > Cc: [email protected] > > > > Signed-off-by: Wei Huang <[email protected]> > > Acked-by: Tianfei Zhang <[email protected]> > > In general, it is better to have 2 separate patches for 2 different issues. >
These two issue are related, if I split them into two patches, the thread cannot work correctly with any one of the patches applied. > Applied > >
