Hi Piotr,
>-----Original Message-----
>From: Zhang, Roy Fan <[email protected]>
>Sent: Wednesday 9 March 2022 14:35
>To: Zhang, Roy Fan <[email protected]>; Bronowski, PiotrX
><[email protected]>; [email protected]
>Cc: [email protected]; [email protected]; Yigit, Ferruh
><[email protected]>; Doherty, Declan <[email protected]>;
>[email protected]; Power, Ciara <[email protected]>
>Subject: RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value
>
>Hi Piotr,
>
>> -----Original Message-----
>> From: Zhang, Roy Fan <[email protected]>
>> Sent: Monday, March 7, 2022 4:27 PM
>> To: Bronowski, PiotrX <[email protected]>; [email protected]
>> Cc: [email protected]; [email protected]; Yigit, Ferruh
>> <[email protected]>; Doherty, Declan <[email protected]>;
>> [email protected]
>> Subject: RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value
>>
>> > -----Original Message-----
>> > From: Bronowski, PiotrX <[email protected]>
>> > Sent: Monday, March 7, 2022 3:33 PM
>> > To: [email protected]
>> > Cc: Zhang, Roy Fan <[email protected]>; [email protected];
>> > [email protected]; Yigit, Ferruh <[email protected]>; Doherty,
>> Declan
>> > <[email protected]>; Bronowski, PiotrX
>> > <[email protected]>; [email protected]
>> > Subject: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value
>> >
>> > This patch removes coverity defect CID 375828:
>> > Untrusted value as argument (TAINTED_SCALAR)
>> >
>> > Coverity issue: CID 375828
>> > Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD")
>> >
>> > Signed-off-by: Piotr Bronowski <[email protected]>
>> >
>> > Cc: [email protected]
>> >
>> > ---
>> > v2: use a different logic to check digest length
>> > ---
>> Acked-by: Fan Zhang <[email protected]>
>
>Sorry I missed a point in your change and thanks for Ciara pointing this out.
>You are changing the gen_digest_size to 64 which is wrong.
>Please send v3.
>Also instead of ack - Nack this patch.
[CP]
In the v3 I think Fixes line should also be updated to either:
Fixes: 746825e5c0ea ("crypto/ipsec_mb: move aesni_gcm PMD")
Or
Fixes: ceb863938708 ("crypto/aesni_gcm: support all truncated digest sizes")
Cc: [email protected]
(The second one seems to be where the code was introduced before being moved
into the consolidated ipsec_mb PMD in 21.11)
Thanks,
Ciara
