On 3/11/2022 7:04 AM, Liu, KevinX wrote:
message moved down, please do not top post
-----Original Message-----
From: Zhang, Yuying <yuying.zh...@intel.com>
Sent: 2022年3月3日 14:30
To: Zhang, Qi Z <qi.z.zh...@intel.com>; Liu, KevinX <kevinx....@intel.com>;
dev <dev@dpdk.org>
Cc: Yang, Qiming <qiming.y...@intel.com>; Yang, SteveX
<stevex.y...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; Xing, Beilei
<beilei.x...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>; dpdk stable
<sta...@dpdk.org>
Subject: RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-
segments
LGTM.
-----Original Message-----
From: Liu, KevinX <kevinx....@intel.com>
Sent: Wednesday, December 29, 2021 5:37 PM
To: dev@dpdk.org
Cc: Yang, Qiming <qiming.y...@intel.com>; Zhang, Qi Z
<qi.z.zh...@intel.com>; Yang, SteveX <stevex.y...@intel.com>; Yigit,
Ferruh <ferruh.yi...@intel.com>; Liu, KevinX <kevinx....@intel.com>;
sta...@dpdk.org
Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in
multi-segments
Testpmd forwards packets in checksum mode that it needs to calculate
the checksum of each layer's protocol.
In process_inner_cksums, when parsing tunnel packets, inner L4
offset should be outer_l2_len + outer_l3_len + l2_len + l3_len.
In process_outer_cksums, when parsing tunnel packets, outer L4
offset should be outer_l2_len + outer_l3_len.
Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi-
segments")
Cc: sta...@dpdk.org
Signed-off-by: Kevin Liu <kevinx....@intel.com>
Acked-by: Yuying Zhang <yuying.zh...@intel.com>
Hi, Ferruh
Yuying has already reviewed it days ago.
If you can, I hope you can change the status as soon as possible and try to
merge the code in RC4.
Thank you.
+Thomas, he is getting patches for -rc4.
And just for double check Qi, are you comfortable with patch?
(I am asking because initially this is set with ice and testpmd patch)
