Kalesh, Ajit, On Tue, Mar 1, 2022 at 1:53 PM David Marchand <[email protected]> wrote: > On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P > <[email protected]> wrote: > > > > From: Kalesh AP <[email protected]> > > > > Fix HWRM_VER_GET command to handle DEV_NOT_RDY state. > > > > Driver should fail probe if the device is not ready. > > Conversely, the HWRM_VER_GET poll after reset can safely > > retry until the existing timeout is exceeded. > > > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > > Cc: [email protected] > > > > Signed-off-by: Kalesh AP <[email protected]> > > Reviewed-by: Somnath Kotur <[email protected]> > > Reviewed-by: Randy Schacher <[email protected]> > > Reviewed-by: Ajit Kumar Khaparde <[email protected]> > > This patch makes probing fail on a RHEL9 kernel with firmwares: > firmware-version: 20.6.143.0/pkg 20.06.04.06 > and > firmware-version: 20.6.112.0 > > Simply reverting the patch fixes probing in my env. > > This was reported by our QE team which is doing sanity checks on ovs > 2.17 which uses dpdk v21.11. > https://bugzilla.redhat.com/show_bug.cgi?id=2055531
QE confirmed reverting this patch fixed initialisation in their setup. I reproduced the issue on another system with RHEL 8.5, and confirmed that reverting the patch or upgrading the firmware fix the issue. I can understand new features in a PMD might require newer firmwares. But breaking compatibility with older firmwares is a big no. If there is no other option, I will send a revert for this patch. Thanks. -- David Marchand
