> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Tuesday, March 29, 2022 7:50 PM > To: Shijith Thotton <[email protected]>; Van Haaren, Harry > <[email protected]>; Jayatheerthan, Jay > <[email protected]>; Carrillo, Erik G <[email protected]>; > Gujjar, Abhinandan S <[email protected]>; McDaniel, Timothy > <[email protected]>; Hemant Agrawal <[email protected]>; > Nipun Gupta <[email protected]>; mattias.ronnblom > <[email protected]>; Ray Kinsella <[email protected]> > Cc: dpdk-dev <[email protected]>; Jerin Jacob <[email protected]>; Pavan > Nikhilesh <[email protected]>; Liang Ma <[email protected]> > Subject: Re: [PATCH 0/6] Extend and set event queue attributes at runtime > > On Tue, Mar 29, 2022 at 6:42 PM Shijith Thotton <[email protected]> wrote: > > > > This series adds support for setting event queue attributes at runtime > > and adds two new event queue attributes weight and affinity. Eventdev > > capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR is added to expose > the > > capability to set attributes at runtime and rte_event_queue_attr_set() > > API is used to set the attributes. > > > > Attributes weight and affinity are not yet added to rte_event_queue_conf > > structure to avoid ABI break and will be added in 22.11. Till then, PMDs > > using the new attributes are expected to manage them.
When the new attributes are added to queue_conf structure in 22.11, will the attr_get() function have any real use? If the attr_get() function is not useful post 22.11 (aka, returns const-integers?), we should consider if waiting for ABI-break in 22.11 is a better solution as it doesn't add public API/ABI functions that only have limited time value..? <snip> > + @Van Haaren, Harry @Jayatheerthan, Jay @Erik Gabriel Carrillo > @Gujjar, Abhinandan S @McDaniel, Timothy @Hemant Agrawal @Nipun > Gupta @Mattias Rönnblom @lingma @Ray Kinsella Thanks for flagging Jerin, indeed I hadn't looked at this patchset yet. From event/sw point of view, the new runtime queue attribute capability is not available, so the feature flag will not be set. <snip> Some code comments inline on the impl patches comping up. Regards, -Harry
