> From: Robin Zhang [mailto:robinx.zh...@intel.com]
> Sent: Wednesday, 20 April 2022 09.00
> 
> Introduce a new telemetry command /ethdev/module_eeprom to show module
> EEPROM for each port. The format of module EEPROM information follows
> the SFF(Small Form Factor) Committee specifications.
> 
> Current the format support SFP(Small Formfactor Pluggable)/SFP+/
> QSFP+(Quad Small Formfactor Pluggable)/QSFP28 with specs SFF-8079/
> SFF-8472/SFF-8024/SFF-8636.
> 
> Afther run the /ethdev/module_eeprom command, both primary application
> and telemetry client will show the module EEPROM information. For
> primary application, we keep the same format with Linux utility
> ethtool,
> refer to command 'ethtool -m' of ethtool v5.4. For telemetry client,
> we record the key value pairs of each item, then show them in telemetry
> client dictionary.

This patch uses printf() a lot. It should only collect the data and give the 
data to the telemetry library, not printf() anything.

It is up to the application (which asked the telemetry library for the data) to 
determine how the data should be presented to the end user. E.g. the 
application could present the data in an SNMP packet, as the response to an 
SNMP request received by the application's SNMP agent. The separation of data 
and presentation is a key point of the telemetry library.

-Morten

Reply via email to