Hi Maxime, David, > -----Original Message----- > From: Maxime Coquelin <[email protected]> > Sent: Friday, April 22, 2022 11:46 PM > To: David Marchand <[email protected]>; Ding, Xuan > <[email protected]> > Cc: Xia, Chenbo <[email protected]>; dev <[email protected]>; Hu, Jiayu > <[email protected]>; Jiang, Cheng1 <[email protected]>; Pai G, Sunil > <[email protected]>; [email protected] > Subject: Re: [PATCH v3 3/5] vhost: merge sync and async descriptor to mbuf > filling > > > > On 4/22/22 13:06, David Marchand wrote: > > We (at RH) have some issues with our email infrastructure, so I can't > > reply inline of the patch. > > > > Copy/pasting the code: > > > > +static __rte_always_inline uint16_t > > +async_poll_dequeue_completed_split(struct virtio_net *dev, uint16_t > > +queue_id, struct rte_mbuf **pkts, uint16_t count, uint16_t dma_id, > > +uint16_t vchan_id, bool legacy_ol_flags) { uint16_t start_idx, from, > > +i; uint16_t nr_cpl_pkts = 0; struct async_inflight_info *pkts_info; > > +struct vhost_virtqueue *vq = dev->virtqueue[queue_id]; > > + > > > > Please, don't pass queue_id as an input parameter for > > async_poll_dequeue_completed_split(). > > The caller of this helper already dereferenced the vq. > > You can pass vq. > > > > > > > I think David's comment was intended to be a reply to patch 4, but I agree > with him. > > Could you please fix this and also fix the build issues reported by the CI? > I'll > continue the review on V4.
Thanks for your suggestion, please see v4. Regards, Xuan > > Thanks, > Maxime
