> -----Original Message----- > From: Pavan Nikhilesh <[email protected]> > Sent: Friday, April 29, 2022 9:17 AM > To: [email protected]; Wang, Yipeng1 <[email protected]>; > Gobriel, Sameh <[email protected]>; Richardson, Bruce > <[email protected]>; Medvedkin, Vladimir > <[email protected]> > Cc: [email protected]; [email protected]; Pavan Nikhilesh > <[email protected]> > Subject: [PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics > > Split x86 and SW hash crc intrinsics into a separate files. > > Signed-off-by: Pavan Nikhilesh <[email protected]> > Reviewed-by: Ruifeng Wang <[email protected]> > --- > v8 Changes: > - Install arch specific headers as indirect headers. > - Retain `rte` prefix for arch specific headers. > v7 Changes: > - Fix build with ppc and other arch. > v6 Changes: > - Simplify rte_hash_crc_set_alg function. (Ruifeng) > v5 Changes: > - Move CRC functions to implementation specific files to remove > ifdef clutter. (Ruifeng) > [Wang, Yipeng] Looks good to me and I believe it is more organized now than before. Thanks for the patch! I did not fully test on x86 though, will rely on the CI or any other reviewer's input.
A little bit grammar issue in commit message: "into separate files" Acked-by: Yipeng Wang <[email protected]>
