Hi Pakai,

On 5/4/22 23:37, Pankaj Gupta wrote:
Hi Andrew,

Changes done in this patch was accidentally removed in commit 046f1161956777e3afb13504acbe8df2ec3a383c.

This was noticed later and we are trying to address this here.

If so, you should add:

Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")
Cc: sta...@dpdk.org


Thanks,

Pankaj

*From: *Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
*Date: *Wednesday, May 4, 2022 at 8:09 AM
*To: *Pankaj Gupta <pagu...@vmware.com>, Jochen Behrens <jbehr...@vmware.com>, Yong Wang <yongw...@vmware.com>
*Cc: *dev@dpdk.org <dev@dpdk.org>
*Subject: *Re: [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature

⚠External Email

On 5/3/22 07:22, Pankaj Gupta wrote:
Fix merge error in initialization for rxDataRing feature.

Is it a bug fix? If so, it requires corresponding "Fixes:" tag and Cc to
sta...@dpdk.org in order to be backported to stable releases.


Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2.

Signed-off-by: Pankaj Gupta <pagu...@vmware.com>
---
   drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +++++
   1 file changed, 5 insertions(+)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c 
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 9955f121f6..6ced76ae2a 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -876,6 +876,11 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
               rqd->conf.rxRingSize[1]   = rxq->cmd_ring[1].size;
               rqd->conf.compRingSize    = rxq->comp_ring.size;

+             if (VMXNET3_VERSION_GE_3(hw)) {
+                     rqd->conf.rxDataRingBasePA = rxq->data_ring.basePA;
+                     rqd->conf.rxDataRingDescSize = rxq->data_desc_size;
+             }
+
               if (hw->intr.lsc_only)
                       rqd->conf.intrIdx = 1;
               else


________________________________

⚠External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.


Reply via email to