> -----Original Message-----
> From: Jeff Daly <je...@silicom-usa.com>
> Sent: Wednesday, April 13, 2022 1:42 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit <steph...@silicom-usa.com>; Wang,
> Haiyue <haiyue.w...@intel.com>
> Subject: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug
>
> Currently the ixgbe driver does not ID any SFP except for the first one
> plugged
> in. This can lead to no-link, or incorrect speed conditions.
Does kernel driver has the same issue for this?
>
> For example:
>
> * If link is initially established with a 1G SFP, and later a 1G/10G
> multispeed
> part is later installed, then the MAC link setup functions are never called to
> change from 1000BASE-X to 10GBASE-R mode, and the link stays running at the
> slower rate.
>
> * If link is initially established with a 1G SFP, and later a 10G only module
> is
> later installed, no link is established, since we are still trasnsmitting in
> 1000BASE-X mode to a 10GBASE-R only partner.
>
> Refactor the SFP ID/setup, and link setup code, to more closely match the flow
> of the mainline kernel driver which does not have these issues. In that
> driver a
> service task runs periodically to handle these operations based on bit flags
> that
> have been set (usually via interrupt or userspace request), and then get
> cleared
> once the requested subtask has been completed.
If kernel driver don't have this issue, Is this the same way that kernel driver
handle this issue?
Btw, could you break down the patch for easy review?
Thanks
Qi