> -----Original Message----- > From: Pei, Andy <andy....@intel.com> > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo....@intel.com>; maxime.coque...@redhat.com; Cao, > Gang <gang....@intel.com>; Liu, Changpeng <changpeng....@intel.com> > Subject: [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct > > Add is_blk flag to ifcvf_hw, and init is_blk during probe. > > Signed-off-by: Andy Pei <andy....@intel.com> > --- > drivers/vdpa/ifc/base/ifcvf.h | 1 + > drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h > index 769c603..8591ef1 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -149,6 +149,7 @@ struct ifcvf_hw { > u8 *lm_cfg; > struct vring_info vring[IFCVF_MAX_QUEUES * 2]; > u8 nr_vring; > + u8 is_blk; > struct ifcvf_pci_mem_resource mem_resource[IFCVF_PCI_MAX_RESOURCE]; > }; > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 0e94e1f..4923bc1 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1536,11 +1536,13 @@ struct rte_vdpa_dev_info dev_info[] = { > > if (device_id == VIRTIO_ID_NET) { > internal->device_type = IFCVF_NET; > + internal->hw.is_blk = IFCVF_NET;
I believe it's enough to keep only device_type. Device type can be defined in internal or internal->hw. Choose the way you prefer. Thanks, Chenbo > internal->features = features & > ~(1ULL << VIRTIO_F_IOMMU_PLATFORM); > internal->features |= dev_info[IFCVF_NET].features; > } else if (device_id == VIRTIO_ID_BLOCK) { > internal->device_type = IFCVF_BLK; > + internal->hw.is_blk = IFCVF_BLK; > internal->features = features & > ~(1ULL << VIRTIO_F_IOMMU_PLATFORM); > internal->features |= dev_info[IFCVF_BLK].features; > -- > 1.8.3.1