Hi Chenbo, Thanks for your reply, I will send out a new version to address this.
> -----Original Message----- > From: Xia, Chenbo <[email protected]> > Sent: Monday, May 23, 2022 11:46 AM > To: Pei, Andy <[email protected]>; [email protected] > Cc: [email protected]; Cao, Gang <[email protected]>; Liu, > Changpeng <[email protected]>; Xu, Rosen <[email protected]>; > Xiao, QimaiX <[email protected]> > Subject: RE: [PATCH v8 02/13] vhost: add vDPA ops for blk device > > > -----Original Message----- > > From: Pei, Andy <[email protected]> > > Sent: Wednesday, May 18, 2022 8:14 PM > > To: [email protected] > > Cc: Xia, Chenbo <[email protected]>; [email protected]; > > Cao, Gang <[email protected]>; Liu, Changpeng > > <[email protected]>; Xu, Rosen <[email protected]>; Xiao, > > QimaiX <[email protected]> > > Subject: [PATCH v8 02/13] vhost: add vDPA ops for blk device > > > > Get_config and set_config are necessary ops for blk device. > > Add get_config and set_config ops to vDPA ops. > > > > Signed-off-by: Andy Pei <[email protected]> > > Reviewed-by: Maxime Coquelin <[email protected]> > > --- > > lib/vhost/vdpa_driver.h | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h index > > 88138be..e59a834 100644 > > --- a/lib/vhost/vdpa_driver.h > > +++ b/lib/vhost/vdpa_driver.h > > @@ -72,8 +72,12 @@ struct rte_vdpa_dev_ops { > > /** Reset statistics of the queue */ > > int (*reset_stats)(struct rte_vdpa_device *dev, int qid); > > > > - /** Reserved for future extension */ > > - void *reserved[2]; > > + /** Get the device configuration space */ > > + int (*get_config)(int vid, uint8_t *config, uint32_t len); > > One suggestion is renaming 'len' to 'size' to make it aligned to set_config. > > With above fixed: > > Reviewed-by: Chenbo Xia <[email protected]> > > > + > > + /** Set the device configuration space */ > > + int (*set_config)(int vid, uint8_t *config, uint32_t offset, > > + uint32_t size, uint32_t flags); > > }; > > > > /** > > -- > > 1.8.3.1
