Sure
> -----Original Message----- > From: Xia, Chenbo <[email protected]> > Sent: Monday, May 23, 2022 3:30 PM > To: Pei, Andy <[email protected]>; [email protected] > Cc: [email protected]; Cao, Gang <[email protected]>; Liu, > Changpeng <[email protected]>; Xu, Rosen <[email protected]>; > Xiao, QimaiX <[email protected]> > Subject: RE: [PATCH v8 08/13] vdpa/ifc: add get device type ops to ifc driver > > > -----Original Message----- > > From: Pei, Andy <[email protected]> > > Sent: Wednesday, May 18, 2022 8:14 PM > > To: [email protected] > > Cc: Xia, Chenbo <[email protected]>; [email protected]; > > Cao, Gang <[email protected]>; Liu, Changpeng > > <[email protected]>; Xu, Rosen <[email protected]>; Xiao, > > QimaiX <[email protected]> > > Subject: [PATCH v8 08/13] vdpa/ifc: add get device type ops to ifc > > driver > > > > Add get device type ops to ifc driver. > > > > Signed-off-by: Andy Pei <[email protected]> > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 3e78c7d..0acfa8c 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1189,6 +1189,29 @@ struct rte_vdpa_dev_info { > > return 0; > > } > > > > +static int > > +ifcvf_get_device_type(struct rte_vdpa_device *vdev, > > + uint32_t *type) > > +{ > > + struct ifcvf_internal *internal; > > + struct internal_list *list; > > + > > + list = find_internal_resource_by_vdev(vdev); > > + if (list == NULL) { > > + DRV_LOG(ERR, "Invalid vDPA device: %p", vdev); > > + return -1; > > + } > > + > > + internal = list->internal; > > + > > + if (internal->hw.device_type == IFCVF_BLK) > > + *type = VDPA_DEVICE_TYPE_BLK; > > + else > > + *type = VDPA_DEVICE_TYPE_NET; > > + > > + return 0; > > +} > > + > > static struct rte_vdpa_dev_ops ifcvf_ops = { > > .get_queue_num = ifcvf_get_queue_num, > > .get_features = ifcvf_get_vdpa_features, @@ -1201,6 +1224,7 @@ > > struct rte_vdpa_dev_info { > > .get_vfio_group_fd = ifcvf_get_vfio_group_fd, > > .get_vfio_device_fd = ifcvf_get_vfio_device_fd, > > .get_notify_area = ifcvf_get_notify_area, > > + .get_dev_type = ifcvf_get_device_type, > > }; > > > > static inline int > > @@ -1327,6 +1351,7 @@ struct rte_vdpa_dev_info { > > .get_vfio_device_fd = ifcvf_get_vfio_device_fd, > > .get_notify_area = ifcvf_get_notify_area, > > .get_config = ifcvf_blk_get_config, > > + .get_dev_type = ifcvf_get_device_type, > > }; > > > > struct rte_vdpa_dev_info dev_info[] = { > > -- > > 1.8.3.1 > > With renaming fixed mentioned in patch 7: > > Reviewed-by: Chenbo Xia <[email protected]>
