> -----Original Message-----
> From: Arek Kusztal <[email protected]>
> Sent: Wednesday, May 25, 2022 9:23 PM
> To: [email protected]
> Cc: Akhil Goyal <[email protected]>; [email protected]; Arek Kusztal
> <[email protected]>
> Subject: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using
> ephemeral key in dsa
>
> External Email
>
> ----------------------------------------------------------------------
> - Removed comment that stated dsa can be used with Diffie
> Hellman ephemeral key.
> DH and DSA integration allowed to use ephemeral keys for
> random integer but not for private keys.
>
> Signed-off-by: Arek Kusztal <[email protected]>
> ---
> lib/cryptodev/rte_crypto_asym.h | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
> index 2b427afa3f..ef8686fda8 100644
> --- a/lib/cryptodev/rte_crypto_asym.h
> +++ b/lib/cryptodev/rte_crypto_asym.h
> @@ -270,13 +270,7 @@ struct rte_crypto_dsa_xform {
> rte_crypto_uint g;
> /**< Generator of the subgroup */
> rte_crypto_uint x;
> - /**< x: Private key of the signer in octet-string network
> - * byte order format.
> - * Used when app has pre-defined private key.
> - * Valid only when xform chain is DSA ONLY.
> - * if xform chain is DH private key generate + DSA, then DSA sign
> - * compute will use internally generated key.
> - */
> + /**< x: Private key of the signer */
> };
Acked-by: Akhil Goyal <[email protected]>
