Thanks Akhil for your reply. It should be okay to apply it after rc1 once you feel better. Thanks Nic
From: Akhil Goyal <gak...@marvell.com> Sent: Monday, June 6, 2022 8:04 AM To: Chautru, Nicolas <nicolas.chau...@intel.com>; dev@dpdk.org; t...@redhat.com; maxime.coque...@redhat.com Cc: tho...@monjalon.net; Kinsella, Ray <ray.kinse...@intel.com>; Richardson, Bruce <bruce.richard...@intel.com>; hemant.agra...@nxp.com; Vargas, Hernan <hernan.var...@intel.com>; david.march...@redhat.com Subject: Re: [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices Hi Nicolas, I wanted to take this in RC1 but I was unwell last couple of days. Can we push it to RC2? If not, please ask Thomas if he has time to pick it directly to main? Regards, Akhil ________________________________ From: Chautru, Nicolas <nicolas.chau...@intel.com<mailto:nicolas.chau...@intel.com>> Sent: Monday, 6 June, 2022, 8:24 pm To: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>>; Akhil Goyal <gak...@marvell.com<mailto:gak...@marvell.com>>; t...@redhat.com<mailto:t...@redhat.com> <t...@redhat.com<mailto:t...@redhat.com>>; maxime.coque...@redhat.com<mailto:maxime.coque...@redhat.com> <maxime.coque...@redhat.com<mailto:maxime.coque...@redhat.com>> Cc: tho...@monjalon.net<mailto:tho...@monjalon.net> <tho...@monjalon.net<mailto:tho...@monjalon.net>>; Kinsella, Ray <ray.kinse...@intel.com<mailto:ray.kinse...@intel.com>>; Richardson, Bruce <bruce.richard...@intel.com<mailto:bruce.richard...@intel.com>>; hemant.agra...@nxp.com<mailto:hemant.agra...@nxp.com> <hemant.agra...@nxp.com<mailto:hemant.agra...@nxp.com>>; Vargas, Hernan <hernan.var...@intel.com<mailto:hernan.var...@intel.com>>; david.march...@redhat.com<mailto:david.march...@redhat.com> <david.march...@redhat.com<mailto:david.march...@redhat.com>> Subject: [EXT] RE: [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices External Email ---------------------------------------------------------------------- Hi Akhil, Checking that this series on track to be applied. Let me know if anything required from our end. > -----Original Message----- > From: Chautru, Nicolas > <nicolas.chau...@intel.com<mailto:nicolas.chau...@intel.com>> > Sent: Tuesday, May 31, 2022 3:32 PM > To: dev@dpdk.org<mailto:dev@dpdk.org>; > gak...@marvell.com<mailto:gak...@marvell.com>; > t...@redhat.com<mailto:t...@redhat.com>; > maxime.coque...@redhat.com<mailto:maxime.coque...@redhat.com> > Cc: tho...@monjalon.net<mailto:tho...@monjalon.net>; Kinsella, Ray > <ray.kinse...@intel.com<mailto:ray.kinse...@intel.com>>; > Richardson, Bruce > <bruce.richard...@intel.com<mailto:bruce.richard...@intel.com>>; > hemant.agra...@nxp.com<mailto:hemant.agra...@nxp.com>; Vargas, Hernan > <hernan.var...@intel.com<mailto:hernan.var...@intel.com>>; > david.march...@redhat.com<mailto:david.march...@redhat.com>; Chautru, Nicolas > <nicolas.chau...@intel.com<mailto:nicolas.chau...@intel.com>> > Subject: [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 > devices > > v7: updates suggested by Akhil and Maxime. Removed RTE prefix for internal > #define, removed build-time single FEC engine configuration mode, > documentation fix, coding guideline fix, renamed new file without rte prefix. > > v6: use formally an unified driver for AC100 and AC101. Exposing single > unified function for the PF device configuration used by bbdev-test. > > v5: minor fix to doc and intermediate commit caught in CI > > v4: incremental updates based on reviews Changed order of patchset to > include two ACC100 specific commits first: updating formally the companion > configure function from PF and the protection adjustment. > Then next 3 commits for the actual changes specific to ACC101: the device > specific function for FCW 5GUL generation used as a local function, > combined documentations into a single .rst common to both devices, > updated comments, removed unused #defines. > > v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test section > calling the configure companion function for ACC100/101, taking the Pmon > commit out which is not directly required. > > v2: Based on good feedback from Thomas and David, now implementing the > ACC101 PMD as a close derivative from existing ACC100 PMD with hooks to > have different behaviour based on variant. > This prevents code duplication and only rely on different functions and > behaviour when hardware requires or support differences. > Note that these are pending changes for ACC100 which would be specific to > that device and not ACC101 but these can be managed based on the new > implementation, ie. is_acc100() etc... (such incremental changes for ACC100 > trending 22.11 but confirming this is future proof). > The serie also includes commits which were meant for ACC101 but are also > valuable for ACC100. > > v1: This serie introduces the PMD for the new bbdev device ACC101 (aka > Mount Cirrus). > This is a derivative from previous Mount Bryce ACC100 which includes silicon > improvement, bug fixes, capacity improvement for 5GNR and feature > improvement. > > > Nicolas Chautru (6): > baseband/acc100: update companion PF configure function > baseband/acc100: add protection for some negative scenario > baseband/acc100: remove RTE prefix for internal macro > baseband/acc100: introduce PMD for ACC101 > baseband/acc100: modify validation code for ACC101 > baseband/acc100: configuration of ACC101 from PF > > MAINTAINERS | 1 + > app/test-bbdev/test_bbdev_perf.c | 6 +- > doc/guides/bbdevs/acc100.rst | 37 +- > doc/guides/bbdevs/features/acc101.ini | 13 + > doc/guides/rel_notes/release_22_07.rst | 3 + > drivers/baseband/acc100/acc100_pf_enum.h | 18 + > drivers/baseband/acc100/acc101_pmd.h | 50 +++ > drivers/baseband/acc100/rte_acc100_cfg.h | 4 +- > drivers/baseband/acc100/rte_acc100_pmd.c | 687 > ++++++++++++++++++++++++++++--- > drivers/baseband/acc100/rte_acc100_pmd.h | 37 +- > drivers/baseband/acc100/version.map | 3 +- > 11 files changed, 768 insertions(+), 91 deletions(-) create mode 100644 > doc/guides/bbdevs/features/acc101.ini > create mode 100644 drivers/baseband/acc100/acc101_pmd.h > > -- > 1.8.3.1
