On Wed, 22 Jun 2022 23:49:39 +0100
Konstantin Ananyev <[email protected]> wrote:
> > @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct
> > rte_ipv4_hdr *dst,
> > const struct rte_ipv4_hdr *src, uint16_t header_len,
> > uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)
> > {
> > - rte_memcpy(dst, src, header_len);
> > + memcpy(dst, src, header_len);
>
>
> I am fine with replacements in test and inside the lib, for cases
> where 'len' parameter is constant value.
> Though as I said before, here 'header_len' is not a constant value.
> Are you sure it will not introduce any performance regression?
Do you have any performance tests. The ip header options are very small.
