On 6/21/22 13:33, Chaoyong He wrote:
This commit implements the flower Rx logic. Fallback packets are
multiplexed to the correct representor port based on the prepended
metadata. The Rx poll is set to run on the existing service
infrastructure.

For Tx the existing NFP Tx logic is duplicated to keep the Tx two paths
distinct. Flower fallback also adds 8 bytes of metadata to the start of
the packet that has to be adjusted for in the Tx descriptor.

Signed-off-by: Chaoyong He <chaoyong...@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderl...@corigine.com>

[snip]

+               if (unlikely(pkt->nb_segs > 1 &&
+                               !(hw->cap & NFP_NET_CFG_CTRL_GATHER))) {
+                       PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set");
+                       rte_panic("Multisegment packet unsupported\n");

checkpatches.sh warnings about it [1]. Please, rework code to
avoid usage of rte_panic().

[1] http://mails.dpdk.org/archives/test-report/2022-June/290996.html

+               }

[snip]

Reply via email to