> -----Original Message-----
> From: Zeng, ZhichaoX <[email protected]>
> Sent: Tuesday, June 28, 2022 2:21 PM
> To: [email protected]
> Cc: [email protected]; Yang, Qiming <[email protected]>; Zhang, Qi Z
> <[email protected]>; Zeng, ZhichaoX <[email protected]>;
> [email protected]; Guo, Junfeng <[email protected]>; Su, Simei
> <[email protected]>; Ferruh Yigit <[email protected]>
> Subject: [PATCH v3] net/igc: move the initialization of data path into
> dev_init
>
> From: Zhichao Zeng <[email protected]>
>
> The upper-layer application usually call the common interface "dev_init"
> to initialize the data path, but in the igc driver, the initialization of
> data path is in
> "igc_rx_init" and "eth_igc_tx_queue_setup", while in other drivers it is in
> "dev_init". So when upper-layer application calling these function pointers
> will
> occur segmentation faults.
NO, for most intel PMD e.g.: i40e and ice, we don't initialize data path in
dev_init.
>
> This patch moves the initialization of data path into "eth_igc_dev_init"
> to avoid segmentation faults, which is consistent with other drivers.
I saw dev->rx_pkt_burst can be overwritten in igc_rx_init, I assume the issue
still be exist.
