15/07/2022 22:30, [email protected]:
> From: Xuan Ding <[email protected]>
> 
> RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time ago to
> substitute bit-field header_split in struct rte_eth_rxmode. It allows
> to enable per-port header split offload with the header size controlled
> using split_hdr_size in the same structure.
> 
> Right now, no single PMD actually supports RTE_ETH_RX_OFFLOAD_HEADER_SPLIT
> with above definition. Many examples and test apps initialize the field
> to 0 explicitly. The most of drivers simply ignore split_hdr_size since
> the offload is not advertised, but some double-check that its value is 0.
> 
> So the RTE_ETH_RX_OFFLOAD_HEADER_SPLIT and split_header_size field
> will be removed in DPDK 22.11. After DPDK 22.11 LTS, the
> RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT can still be used for per-queue Rx
> packet split offload, which is configured by rte_eth_rxseg_split.
> 
> Signed-off-by: Xuan Ding <[email protected]>
> Acked-by: Ray Kinsella <[email protected]>
> Acked-by: Andrew Rybchenko <[email protected]>
> Acked-by: Ferruh Yigit <[email protected]>
> Acked-by: Viacheslav Ovsiienko <[email protected]>
Acked-by: Thomas Monjalon <[email protected]>

This v2 is a lot better for the users to understand what happens.
Fixed the indent and moved few words:

* ethdev: Since no single PMD supports ``RTE_ETH_RX_OFFLOAD_HEADER_SPLIT``
  offload and the ``split_hdr_size`` field in structure ``rte_eth_rxmode``
  to enable per-port header split, they will be removed in DPDK 22.11.
  The per-queue Rx packet split offload ``RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT``
  can still be used, and it is configured by ``rte_eth_rxseg_split``.

Applied, thanks.


Reply via email to