Hi Kai, Will fix the is duplication of OPENSSL_VERSION_NUMBER check.
Some CMAC tests are already present. The number of successful tests in cryptodev_openssl_autotest increases by 4 with this change. I am not planning to add more. Regards, Ashwin Sekhar T K > -----Original Message----- > From: Ji, Kai <[email protected]> > Sent: Monday, July 18, 2022 7:27 PM > To: Ashwin Sekhar Thalakalath Kottilveetil <[email protected]> > Cc: Anoob Joseph <[email protected]>; [email protected]; Akhil Goyal > <[email protected]>; Harman Kalra <[email protected]>; Jerin Jacob > Kollanukkaran <[email protected]>; Kiran Kumar Kokkilagadda > <[email protected]>; Nithin Kumar Dabilpuram > <[email protected]>; Pavan Nikhilesh Bhagavatula > <[email protected]>; Satheesh Paul Antonysamy > <[email protected]>; Zhang, Roy Fan <[email protected]>; > Sunil Kumar Kori <[email protected]>; Satha Koteswara Rao Kottidi > <[email protected]> > Subject: [EXT] RE: [PATCH v4 0/1] crypto/openssl: add aes cmac support > > External Email > > ---------------------------------------------------------------------- > Hi Ashwin, > > There is duplication of OPENSSL_VERSION_NUMBER check in v4, right > before process_openssl_auth_mac(). > Are you planning to enable CMAC unit test case in > cryptodev_openssl_autotest ? > > Regards > > Kai > > > > -----Original Message----- > > From: Ashwin Sekhar T K <[email protected]> > > Sent: Monday, July 18, 2022 10:19 AM > > To: [email protected] > > Cc: [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; > > [email protected]; Zhang, Roy Fan <[email protected]>; > > [email protected]; [email protected] > > Subject: [PATCH v4 0/1] crypto/openssl: add aes cmac support > > > > Add support for aes cmac operations. > > > > v2: > > * Added support for openssl 3.0 > > v3: > > * Fixed checkpatch warnings. > > v4: > > * Fixed more checkpatch warnings. > > > > Ashwin Sekhar T K (1): > > crypto/openssl: support aes cmac operations > > > > drivers/crypto/openssl/openssl_pmd_private.h | 14 ++ > > drivers/crypto/openssl/rte_openssl_pmd.c | 142 > ++++++++++++++++++- > > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 20 +++ > > 3 files changed, 169 insertions(+), 7 deletions(-) > > > > -- > > 2.25.1
