> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Wednesday, August 3, 2022 23:12
> To: Guo, Junfeng <[email protected]>
> Cc: Zhang, Qi Z <[email protected]>; Wu, Jingjing
> <[email protected]>; Xing, Beilei <[email protected]>;
> [email protected]; Li, Xiaoyun <[email protected]>; Wang, Xiao W
> <[email protected]>
> Subject: Re: [PATCH 03/13] net/idpf: support device initialization
>
> On Wed, 3 Aug 2022 19:30:54 +0800
> Junfeng Guo <[email protected]> wrote:
>
> > +
> > +static int
> > +idpf_dev_configure(struct rte_eth_dev *dev)
> > +{
> > + struct idpf_vport *vport =
> > + (struct idpf_vport *)dev->data->dev_private;
>
> Cast of void pointer dev_private is unnecessary in C (only in C++ is it
> needed).
>
> > + int ret = 0;
>
> Useless initialization, you are setting in next line.
Thanks for your review! Will refine this in the patchset of upcoming version.
>
> > +
> > + ret = idpf_init_vport_req_info(dev);
> > + if (ret) {
