Hi Stephen
Many thanks for your review.
On 2022/9/20 23:21, Stephen Hemminger wrote:
On Tue, 20 Sep 2022 18:51:42 +0800
Dongdong Liu <[email protected]> wrote:
From: "Min Hu (Connor)" <[email protected]>
This patch add support for dump dpdk version and ethdev firmware version.
The command is like:
dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- --show-version
Signed-off-by: Min Hu (Connor) <[email protected]>
Signed-off-by: Dongdong Liu <[email protected]>
---
Why mix DPDK and firmware version in one option?
Like ethtool -i command, one command can show kernel version
and ethdev firmware version.
ethtool -i eth0
driver: hns3
version: 5.13.0-rc4+
firmware-version: 1.20.0.17
Why not use semi-standard convention of -V --version option for DPDK version
and add --firmware-version option to show firmware.
Looks good, will do.
Thanks,
Dongdong
.
